fix for python requests module >= 1.0.0 for from_response#24
Open
buckmaxwell wants to merge 2 commits intointernetarchive:masterfrom
Open
fix for python requests module >= 1.0.0 for from_response#24buckmaxwell wants to merge 2 commits intointernetarchive:masterfrom
buckmaxwell wants to merge 2 commits intointernetarchive:masterfrom
Conversation
added 2 commits
June 27, 2016 14:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the request module versions >= 1.0.0, full_url attribute does not exist, so this method will not work. By wrapping in a try catch, this remains backward compatible w/ older versions of the module and th method will now be able to support new request responses.